New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[rb] Ensure server is started with Bazel JDK #13882
base: trunk
Are you sure you want to change the base?
Conversation
PR Description updated to latest commit (a57778f)
|
PR Review
✨ Review tool usage guide:Overview: The tool can be triggered automatically every time a new PR is opened, or can be invoked manually by commenting on any PR.
See the review usage page for a comprehensive guide on using this tool. |
PR Code Suggestions
✨ Improve tool usage guide:Overview:
See the improve usage page for a comprehensive guide on using this tool. |
CI Failure Feedback(Checks updated until commit afaf1c2)
✨ CI feedback usage guide:The CI feedback tool (
In addition to being automatically triggered, the tool can also be invoked manually by commenting on a PR:
where Configuration options
See more information about the |
c7f3f8f
to
b75cf82
Compare
b75cf82
to
036da88
Compare
User description
Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Description
Motivation and Context
Types of changes
Checklist
Type
enhancement
Description
SELENIUM_BAZEL_SERVER_LAUNCHER
.Changes walkthrough
server.rb
Support Bazel JDK Launcher for Server Command
rb/lib/selenium/server.rb
SELENIUM_BAZEL_SERVER_LAUNCHER
environmentvariable if present.
test_environment.rb
Configure Test Environment for Bazel JDK Launcher
rb/spec/integration/selenium/webdriver/spec_support/test_environment.rb
SELENIUM_BAZEL_SERVER_LAUNCHER
environmentvariable for test setup.
tests.bzl
Update Test Configurations for Bazel Server
rb/spec/tests.bzl
file.
configurations.