New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[rb] Use Bazel JDK when starting server #13771
Conversation
PR Description updated to latest commit (66adbbb)
|
PR Review
✨ Review tool usage guide:Overview: The tool can be triggered automatically every time a new PR is opened, or can be invoked manually by commenting on any PR.
See the review usage page for a comprehensive guide on using this tool. |
PR Code Suggestions
✨ Improve tool usage guide:Overview:
See the improve usage page for a comprehensive guide on using this tool. |
CI Failure Feedback(Checks updated until commit ef437df)
✨ CI feedback usage guide:The CI feedback tool (
In addition to being automatically triggered, the tool can also be invoked manually by commenting on a PR:
where Configuration options
See more information about the |
This ensures the server is not started with a system JDK which might be missing, outdated or simply inaccessible due to Bazel test sandboxing.
66adbbb
to
fd0fe80
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Replaced by #13882 |
User description
This ensures the server is not started with a system JDK which might be missing, outdated or simply inaccessible due to Bazel test sandboxing.
Type
enhancement
Description
java_bin
to dynamically select the Java binary based on the environment, specifically for Bazel tests.java_bin
, enhancing compatibility with Bazel's sandboxed environment.Changes walkthrough
server.rb
Use Bazel JDK for Selenium Server Initialization
rb/lib/selenium/server.rb
java_bin
method for determining Javabinary path.
java_bin
method to select Java binary fromJAVA_HOME
ifBAZEL_TEST
environment variable is set, otherwise defaults to 'java'.