Simplify dependency constraints in gemspec #681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Looking at the latest release, 1.16.0 it depends on the it depends on everything in the `else` branches in the gemspec. https://rubygems.org/gems/ruby-saml/versions/1.16.0 Runtime nokogiri >= 1.13.10 rexml >= 0 Development minitest ~> 5.5, < 5.19.0 mocha ~> 0.14 pry-byebug >= 0 rake >= 12.3.3 shoulda ~> 2.11 simplecov < 0.22.0 simplecov-lcov > 0.7.0 systemu ~> 2 timecop ~> 0.9 There has also never been a JRuby specific version published: https://rubygems.org/gems/ruby-saml/versions so remove all special handling for JRuby. If CI shows any need for it, we can add back constraints in the Gemfile.
ruby-saml depends on at least nokogiri 1.13.10 since v1.15.0: SAML-Toolkits@9b6e3e9 Nokogiri 1.13.10 require at least Ruby 2.6.0, which means no Ruby <2.6 can install ruby-saml >= 1.15.0 Bump the required version in the gemspec and drop all CI builds for Ruby <2.6 (JRuby targets 2.6.x from 9.3).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looking at the latest release, 1.16.0 it depends on the it depends on everything in the
elsebranches in the gemspec. https://rubygems.org/gems/ruby-saml/versions/1.16.0Runtime
Development
There has also never been a JRuby specific version published: https://rubygems.org/gems/ruby-saml/versions
so remove all special handling for JRuby.
If CI shows any need for it, we can add back constraints in the Gemfile.