Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add base64 gem dependency for Ruby 3.4 compatibility #680

Open
casperisfine opened this issue Mar 28, 2024 · 1 comment
Open

Add base64 gem dependency for Ruby 3.4 compatibility #680

casperisfine opened this issue Mar 28, 2024 · 1 comment

Comments

@casperisfine
Copy link

I wanted to submit a PR but was a bit surprised with the gemspec and wasn't sure how to add a dependency in it.

So just a quick heads up that Ruby 3.4 will make base64 a "bundled gems", meaning gems now need to declare their dependency on it: https://bugs.ruby-lang.org/issues/20187

@dentarg
Copy link
Contributor

dentarg commented Apr 11, 2024

Trying to simplify the gemspec in #681

Since 9b6e3e9 the required Ruby version for ruby-saml is effectively Ruby 2.6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants