New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #579 buildWithBaseURLPath return only last part of url #581

Merged

pitbulk merged 1 commit into SAML-Toolkits:4.x-dev from ubc-cpsc:579-fixes-nested-sub-path

May 30, 2024

joelpittet commented Mar 18, 2024

The array_pop() assumes the last part of the path is the only valid leading an invalid_response error:

"The response was received at https://example.com/sub-directory/acs instead of https://example.com/sub-directory/saml/acs"


          Fixes SAML-Toolkits#579 Nested sub path parsing

919e78f

joelpittet mentioned this pull request

Fixes #579 buildWithBaseURLPath return only last part of url #580

Closed

Author

joelpittet commented Mar 18, 2024

This should help fix #579

This was referenced Mar 18, 2024

Fix: buildWithBaseURLPath corrupts the current route if it contains slashes, causing assertion validation to fail #249 #555

Open

buildWithBaseURLPath corrupts the current route if it contains slashes, causing assertion validation to fail #249

Open

Utils::buildWithBaseURLPathdoes not provides a correct url. #464

Open

pitbulk merged commit 9d6ccc0 into SAML-Toolkits:4.x-dev

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment