Fix: buildWithBaseURLPath corrupts the current route if it contains slashes, causing assertion validation to fail #249 #555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix buildWithBaseURLPath corrupts the current route if it contains slashes, causing assertion validation to fail
|
@malekbig It seems your fix breaks a test |
joelpittet
reviewed
Mar 18, 2024
| if (!empty($baseURLPath) && !empty($info)) { | ||
| $path = explode('/', $info); | ||
| if (count($path) > 1) { | ||
| $info = implode(array_filter($path), '/'); |
There was a problem hiding this comment.
implode arguments are backwards. https://www.php.net/implode
|
Also the subdirectory now gets duplicated if you fix the argument issue with I'm trying to solve a similar issue with this function. The |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix buildWithBaseURLPath corrupts the current route if it contains slashes, causing assertion validation to fail