Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated _collections_abc.py and test_collections.py to CPython 3.11.2 #5016

Merged
merged 2 commits into from
Jun 18, 2023

Conversation

bobby-palmer
Copy link
Contributor

@bobby-palmer bobby-palmer commented Jun 18, 2023

#4564 updating _collections_abc.py to 3.11.2 for Python

@DimitrisJim
Copy link
Member

DimitrisJim commented Jun 18, 2023

thanks @bobby-palmer, this might be a tricky one 😄 there's two test cases now failing in Lib/test/test_typing.py:

test_errors (test.test_typing.CollectionsCallableTests.test_errors)
test_valid_uses (test.test_typing.ParamSpecTests.test_valid_uses)

You can open that file and decorate them with unittest.expectedFailure to mark them as so. For test_errors you can add this function to CollectionsCallableTests:

    # TODO: RUSTPYTHON
    @unittest.expectedFailure
    def test_errors(self): # TODO: RUSTPYTHON, remove when this passes
        super().test_errors() # TODO: RUSTPYTHON, remove when this passes

while for test_valid_uses just mark the function directly since it isn't brought in via inheritance:

    # TODO: RUSTPYTHON
    @unittest.expectedFailure
    def test_valid_uses(self):
        ....  # function body unchanged

@bobby-palmer
Copy link
Contributor Author

@DimitrisJim thanks for the feedback! those tests should be fixed now

Copy link
Member

@DimitrisJim DimitrisJim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, guess this wasn't tricky after all. thanks!

@DimitrisJim DimitrisJim merged commit 500b002 into RustPython:main Jun 18, 2023
11 checks passed
@bobby-palmer bobby-palmer deleted the updated_collections_abc.py branch June 18, 2023 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants