Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update python libraries and tests from CPython 3.11 #4564

Closed
youknowone opened this issue Feb 24, 2023 · 16 comments
Closed

Update python libraries and tests from CPython 3.11 #4564

youknowone opened this issue Feb 24, 2023 · 16 comments
Labels
A-stdlib E-help-wanted Extra attention is needed good first issue Good for newcomers

Comments

@youknowone
Copy link
Member

youknowone commented Feb 24, 2023

Though it will be sometimes blocked by rust side issues, don't worry!
Please just create PR about the broken test and and create issues related to the new bugs.

If you are new to updating cpython libraries, this guide will be useful:
https://github.com/RustPython/RustPython/wiki/How-to-update-test-files

When updating module Lib/X, please don't forget to also update Lib/test/test_X

A few libraries doesn't need to be updated because CPython also kept it same as previous version. In that case, please leave a comment to let us mark it as done. Thank you!

Tips

  • To get specific version of CPython source code, try git checkout v3.11.2 from CPython repository.
  • Please check Update libraries and tests from CPython 3.10.6 #4064 for example. Not the entire changes but the each commits. One of the middle size example is 17e12de . Sometimes it can be really simple like 9571a68
  • Please create one PR for one library+test pair whenever possible. Once you stuck by dependencies, go to one of the dependency first and finish it before restarting the stuck one unless they become simpler to be updated at the same time. Normally adding more libraries make passing tests (a lot) harder.
  • To run tests, try cargo run --features ssl -- -m test -v <test_name>. e.g. If you changed test_unicode.py, cargo run --features ssl -- -m test -v test_unicode
    • If it runs too slow, try to add --release like cargo run --release --features ssl -- -m test -v test_unicode

List of libraries

List of tests without python libraries

Not yet added libraries

These libraris are not added yet. Pure python one will be possible while others are not.

@youknowone youknowone changed the title Update python libraries from CPython 3.11 Update python libraries and tests from CPython 3.11 Feb 25, 2023
@youknowone youknowone added good first issue Good for newcomers E-help-wanted Extra attention is needed labels Feb 25, 2023
@youknowone youknowone pinned this issue Feb 25, 2023
@fanninpm

This comment was marked as resolved.

@DimitrisJim
Copy link
Member

Pasting the comment (#4592 (review)) here too for anyone else who might need it:

You can use the following command to test your changes locally (in a manner similar to RustPython's CI):

# this runs all of the tests (not necessary if you know which test is affected)
cargo run --release --features ssl,jit -- -m test -j 1 -u all --slowest --fail-env-changed -v
# this runs only the test suite named "test_whatever" (usually located at `Lib/test/test_whatever.py`)
cargo run --release --features ssl,jit -- -m test -j 1 -u all --slowest --fail-env-changed -v test_whatever

For a list of all resources and more command-line options, you can execute cargo run --release --features ssl,jit -- -m test -h

@dalinaum

This comment was marked as resolved.

@dalinaum

This comment was marked as resolved.

@dalinaum

This comment was marked as resolved.

@dalinaum

This comment was marked as resolved.

@Masorubka1

This comment was marked as resolved.

@Masorubka1

This comment was marked as resolved.

@MegasKomnenos

This comment was marked as resolved.

dvermd added a commit to dvermd/RustPython that referenced this issue Oct 1, 2023
dvermd added a commit to dvermd/RustPython that referenced this issue Oct 1, 2023
dvermd added a commit to dvermd/RustPython that referenced this issue Oct 2, 2023
dvermd added a commit to dvermd/RustPython that referenced this issue Oct 2, 2023
youknowone pushed a commit that referenced this issue Oct 3, 2023
@youknowone
Copy link
Member Author

Thanks to everyone who participated in this series of patches! I am going to close this issue in favor of #5104

@youknowone youknowone unpinned this issue Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-stdlib E-help-wanted Extra attention is needed good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

10 participants