Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update imp.py from CPython 3.11 #5054

Merged
merged 3 commits into from
Aug 31, 2023
Merged

update imp.py from CPython 3.11 #5054

merged 3 commits into from
Aug 31, 2023

Conversation

Reid00
Copy link
Contributor

@Reid00 Reid00 commented Aug 30, 2023

related: #4564

@youknowone
Copy link
Member

This PR contains previously merged commit about test_hashlib.
You probably want to use git rebase or git reset --hard to clear the upstream context before making a patch.
Using patch branches rather than main will also be helpful to make those work easier.

@youknowone
Copy link
Member

Would you check if your git email configuration matches to the github id?

Checking current config:

git config user.email

You can change either the local config or GitHub config to make them aligned

@Reid00
Copy link
Contributor Author

Reid00 commented Aug 31, 2023

Thank you for your advice. I changed the local user.email and will use patch branches.

Copy link
Member

@youknowone youknowone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for contributing!

@youknowone youknowone merged commit 3900a08 into RustPython:main Aug 31, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants