Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add formio POC #84

Merged
merged 3 commits into from Sep 23, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion .babelrc
@@ -1,6 +1,6 @@
{
"plugins": ["@roundingwellos/babel-plugin-handlebars-inline-precompile"],
"presets": [["@babel/preset-env", { "useBuiltIns": "usage", "corejs": 2 }]],
"presets": [["@babel/preset-env", { "useBuiltIns": "usage", "corejs": 3 }]],
"env": {
"test": {
"plugins": [ "istanbul" ]
Expand Down
5 changes: 4 additions & 1 deletion .stylelintrc
@@ -1,9 +1,11 @@
{
"extends": "stylelint-config-recommended-scss",
"extends": "stylelint-config-recommended",
"plugins": [
"stylelint-scss",
"stylelint-order"
],
"rules": {
"at-rule-no-unknown": null,
"font-family-no-missing-generic-family-keyword": null,
"indentation": 2,
"length-zero-no-unit": true,
Expand All @@ -14,6 +16,7 @@
"no-missing-end-of-source-newline": true,
"order/properties-alphabetical-order": true,
"property-case": "lower",
"scss/at-rule-no-unknown": true,
"string-quotes": "single",
"unit-case": "lower",
"value-keyword-case": "lower"
Expand Down
2 changes: 1 addition & 1 deletion config/webpack.env.js
@@ -1,7 +1,7 @@
const path = require('path');

module.exports = {
isCI: process.env.CI,
isCI: !!process.env.CI,
isProduction: process.env.NODE_ENV === 'production',
jsRoot: path.resolve(process.cwd(), './src/js'),
sassRoot: path.resolve(process.cwd(), './src/sass'),
Expand Down
3 changes: 1 addition & 2 deletions config/webpack.rules.js
Expand Up @@ -54,10 +54,9 @@ const postcssLoader = {
const sassLoader = {
loader: 'sass-loader',
options: {
sourceMap: !isProduction,
// Must import global variables/configs with each file
// https://github.com/webpack-contrib/sass-loader/issues/218#issuecomment-266669156
data: `@import \'${ sassRoot }/provider-variables.scss\';`,
prependData: `@import \'${ sassRoot }/provider-variables.scss\';`,
},
};

Expand Down