Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add formio POC #84

Merged
merged 3 commits into from Sep 23, 2019
Merged

Add formio POC #84

merged 3 commits into from Sep 23, 2019

Conversation

paulfalgout
Copy link
Member

  • Add the Clubhouse Story ID: [ch21006]

@cypress
Copy link

cypress bot commented Sep 18, 2019 •
edited


Test summary

46 • 0 • 0 • 0

Run details
Project RoundingWell Care Ops Frontend
Status Passed
Commit 2800b1b
Started Sep 18, 2019 1:49 PM
Ended Sep 18, 2019 1:49 PM
Duration 00:49 💡
OS Linux Debian - 9.6
Browser Electron 61

View run in Cypress Dashboard ➡️

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@paulfalgout
Copy link
Member Author

Something strange going on with istanbul and the handlebars update handlebars-lang/handlebars.js#1553 I'm going to revert that update shortly. I think the test are ok, but I need to test further.

@codecov
Copy link

codecov bot commented Sep 18, 2019 •
edited

Codecov Report

Merging #84 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop      #84   +/-   ##
========================================
  Coverage    97.62%   97.62%           
========================================
  Files           79       79           
  Lines         1434     1434           
========================================
  Hits          1400     1400           
  Misses          34       34

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a56198...2800b1b. Read the comment docs.

@paulfalgout
Copy link
Member Author

Going to rebuild the commits, but here's the form example: https://fe-feature-ch21006-formio-poc.preview.roundingwell.com/forms/12345

@paulfalgout
Update dependencies and add formio dependencies
43c4a9d 
Updating dependencies reduces our overall installs, but our libs won't share dependencies.
@paulfalgout
Add default redirect
7172fee 
If a redirectPath isn't in localStorage it's possible for login to try and route to `authenticate/`.  This change ensures that the user is at least redirected somewhere valid.
@paulfalgout
Add form app routing and load example form.
2800b1b
@paulfalgout paulfalgout merged commit bad9bec into develop Sep 23, 2019
@paulfalgout paulfalgout deleted the feature/ch21006-formio-poc branch September 23, 2019 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luketlancaster luketlancaster luketlancaster approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@paulfalgout @luketlancaster