[examples] Fix some smoke test path snafus #21452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hard-coding paths to runfiles is incompatible with bzlmod. We should always use python.runfiles, or (in the case of acrobot) just use our simple add_test_rule pattern.
jwnimmer-tri
added
priority: low
status: single reviewer ok
|
+@ggould-tri for both reviews, please. No hurry. |
ggould-tri
reviewed
May 20, 2024
There was a problem hiding this comment.
Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status:complete! all discussions resolved, LGTM from assignee ggould-tri(platform)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hard-coding paths to runfiles is incompatible with bzlmod. We should always use
python.runfiles, or (in the case of acrobot) just use our simpleadd_test_rulepattern.Towards #20731.
This change is