New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix missing properties for UnitEnum
and BackedEnum
interfaces
#971
Conversation
May I add: what the fuck? |
Original issue from here :) phpstan/phpstan#6385 |
The CI fails because you need this commit :) ondrejmirtes@b5d9ca3 It's about updating phpstorm-stubs so that in earlier PHP versions classes and interfaces don't implement/extend things from newer PHP versions. I think I'm gonna leave that to @kukulich because it needs some more work :) |
@ondrejmirtes does #972 cover the missing details needed for this one? |
AFAIK #972 fixes PhpStormStubsSourceStubber which is currently buggy - you ask for some class reflection, ask for its parent class and it crashes because it extends something it doesn't exist yet. So it can land in 5.0.x. |
I agree with @ondrejmirtes, eg. |
If anyone can rebase this one, we can 🚢 |
adfd65b
to
d097ba3
Compare
d097ba3
to
10b343a
Compare
Looks like it's going to be green :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
UnitEnum
and BackedEnum
interfaces
Thanks @ondrejmirtes! |
Interface really should not have any properties but we have UnitEnum and BackedEnum Roave#971
Phew, interfaces with properties...
This one actually fixes a couple of problems: