Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Interface can have only public properties #1247

Merged
merged 1 commit into from Sep 28, 2022
Merged

Interface can have only public properties #1247

merged 1 commit into from Sep 28, 2022

Conversation

kukulich
Copy link
Collaborator

Interface really should not have any properties but we have UnitEnum and BackedEnum #971

@kukulich
Interface can have only public properties
23c358c 
Interface really should not have any properties but we have UnitEnum and BackedEnum Roave#971
@kukulich kukulich added this to the 6.0.0 milestone Sep 28, 2022
@Ocramius Ocramius self-assigned this Sep 28, 2022
Ocramius
Ocramius approved these changes Sep 28, 2022
View reviewed changes
Copy link
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚢

@Ocramius Ocramius marked this pull request as ready for review September 28, 2022 14:44
@Ocramius
Copy link
Member

BTW:

0 covered mutants were not detected

I wonder if we should raise the threshold for preventing any mutant from making it through now 🤔

@kukulich kukulich merged commit 02d0233 into Roave:6.0.x Sep 28, 2022
@kukulich kukulich deleted the mutants branch September 28, 2022 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ocramius Ocramius Ocramius approved these changes

Assignees

@Ocramius Ocramius

Labels
enhancement
Projects
None yet
Milestone
6.0.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kukulich @Ocramius