[fix] introduce helper method to prevent push maximum call stack size exceeded error #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… exceeded error Fixes Rich-Harris#40 Alternative to Rich-Harris#64 Part of sveltejs/svelte#4694
dummdidumm
pushed a commit
to dummdidumm/svelte
that referenced
this pull request
Jan 29, 2022
… exceeded error Part of sveltejs#4694 Also related: Rich-Harris/code-red#71
5 tasks
benmccann
reviewed
Jan 29, 2022
src/utils/push_array.js
Outdated
| for (let i = 0; i < items.length; i++) { | ||
| array.push(items[i]); | ||
| } | ||
| }; |
There was a problem hiding this comment.
it looks like there's whitespace before the } which shouldn't be necessary. same above before the export
There was a problem hiding this comment.
I'm no longer able to format code since using Prettier 😄 Fixed
src/utils/push_array.js
Outdated
| * Does `array.push` for all `items`. | ||
| * Needed because `array.push(...items)` throws | ||
| * "Maximum call stack size exceeded" when items | ||
| * is too big of an array |
There was a problem hiding this comment.
this seems like a pretty short line wrap length
benmccann
approved these changes
Jan 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in the maintainers meeting, this just introduces a simple
push_arraymethodFixes #40
Alternative to / closes #64
Part of sveltejs/svelte#4694
Credit to @milahu for finding the issue, we should add a "co-authored by"-message to the merge.