Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix] prevent maximum call stack size exceeded error on large pages #7203

Merged
merged 4 commits into from Jan 31, 2022
Merged

[fix] prevent maximum call stack size exceeded error on large pages #7203

merged 4 commits into from Jan 31, 2022

Conversation

dummdidumm
Copy link
Member

Part of #4694
Also related: Rich-Harris/code-red#71
Alternative to/closes #6716

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with [feat], [fix], [chore], or [docs].
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with npm test and lint the project with npm run lint

bluwy
bluwy approved these changes Jan 30, 2022
View reviewed changes
Copy link
Member

@bluwy bluwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can credit @milahu here too for finding the core issue.

@dummdidumm
Copy link
Member Author

Yeah if this gets merged we definitely should add a "co-authored by"-message

@milahu milahu mentioned this pull request Jan 30, 2022
Closed
5 tasks
@benmccann benmccann changed the title [fix] introduce helper method to prevent push maximum call stack size exceeded error [fix] prevent maximum call stack size exceeded error on large pages Jan 31, 2022
@benmccann
Copy link
Member

Thanks for tackling this @dummdidumm and @milahu! I've bumped code-red and will go ahead and merge this

Conduitry
Conduitry reviewed Jan 31, 2022
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@benmccann @Conduitry
Update CHANGELOG.md
7d8d85a 
Co-authored-by: Conduitry <git@chor.date>
@benmccann benmccann merged commit be3d827 into sveltejs:master Jan 31, 2022
@dummdidumm dummdidumm deleted the fix-max-callstackesize branch February 1, 2022 07:42
himanshiLt pushed a commit to himanshiLt/svelte that referenced this pull request Mar 3, 2022
@dummdidumm @milahu
@benmccann @himanshiLt
[fix] prevent maximum call stack size exceeded error on large pages (s…
dda54a7 
…veltejs#7203)

Co-authored-by: milahu <milahu@gmail.com>
Co-authored-by: Simon <simon.holthausen@accso.de>
Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>
nevilm-lt pushed a commit to nevilm-lt/svelte that referenced this pull request Mar 14, 2022
@dummdidumm @milahu
@benmccann @nevilm-lt
[fix] prevent maximum call stack size exceeded error on large pages (s…
c482fd5 
…veltejs#7203)

Co-authored-by: milahu <milahu@gmail.com>
Co-authored-by: Simon <simon.holthausen@accso.de>
Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>
nevilm-lt pushed a commit to nevilm-lt/svelte that referenced this pull request Apr 21, 2022
@dummdidumm @milahu
@benmccann @nevilm-lt
[fix] prevent maximum call stack size exceeded error on large pages (s…
33eb9a3 
…veltejs#7203)

Co-authored-by: milahu <milahu@gmail.com>
Co-authored-by: Simon <simon.holthausen@accso.de>
Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>
nevilm-lt pushed a commit to nevilm-lt/svelte that referenced this pull request Apr 21, 2022
@dummdidumm @milahu
@benmccann @nevilm-lt
[fix] prevent maximum call stack size exceeded error on large pages (s…
159db44 
…veltejs#7203)

Co-authored-by: milahu <milahu@gmail.com>
Co-authored-by: Simon <simon.holthausen@accso.de>
Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>
nevilm-lt pushed a commit to nevilm-lt/svelte that referenced this pull request Apr 22, 2022
@dummdidumm @milahu
@benmccann @nevilm-lt
[fix] prevent maximum call stack size exceeded error on large pages (s…
573def0 
…veltejs#7203)

Co-authored-by: milahu <milahu@gmail.com>
Co-authored-by: Simon <simon.holthausen@accso.de>
Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benmccann benmccann benmccann approved these changes

@Conduitry Conduitry Conduitry approved these changes

@bluwy bluwy bluwy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dummdidumm @benmccann @Conduitry @bluwy