Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated marked to 0.5.2 #734

Merged
merged 1 commit into from Dec 6, 2018
Merged

Updated marked to 0.5.2 #734

merged 1 commit into from Dec 6, 2018

Conversation

softbrix
Copy link
Contributor

@softbrix softbrix commented Dec 6, 2018

Now that marked.js has published a new version you can remove the dependency to specific git commit so we can fetch all dependencies from official releases to npmjs.

Updated version for the marked dependency to an official release.
@RomanHotsiy
Copy link
Member

makred.js merged one more my PR: markedjs/marked#1383

If you are not blocked, let's wait until the new marked release

@softbrix
Copy link
Contributor Author

softbrix commented Dec 6, 2018

I have a working solution for it for now.
Added the following to my package-lock.json in the redoc block:

      "dependencies": {
        "marked": {
          "version": "0.5.2",
          "from": "git+https://github.com/markedjs/marked.git#fb48827236ed3a43e611d2adb3c070ca3f55ed8e"
        }
      }

Lets wait for an update =)

@softbrix softbrix closed this Dec 6, 2018
@RomanHotsiy RomanHotsiy reopened this Dec 6, 2018
@RomanHotsiy RomanHotsiy merged commit 809e7f2 into Redocly:master Dec 6, 2018
@RomanHotsiy
Copy link
Member

@lpinca says (here) that using commit makes his coworkers maintain dirty hacks so merging this.
Not sure when marked@0.5.3 will be cut.

@RomanHotsiy
Copy link
Member

Thanks, @softbrix and @lpinca 🙌

@lpinca
Copy link
Contributor

lpinca commented Dec 6, 2018

@RomanGotsiy thank you very much.

@softbrix
Copy link
Contributor Author

softbrix commented Dec 6, 2018

@RomanGotsiy thank you for your work with this awesome module!

@coveralls
Copy link

Coverage Status

Coverage remained the same at 82.204% when pulling e6b28de on softbrix:patch-2 into 4f60ec8 on Rebilly:master.

@softbrix softbrix deleted the patch-2 branch December 11, 2018 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants