Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use tarball url for marked dependency #725

Closed
wants to merge 1 commit into from

Conversation

lpinca
Copy link
Contributor

@lpinca lpinca commented Nov 27, 2018

Allow the dependency to be installed without git.

Allow the dependency to be installed without git.
@lpinca
Copy link
Contributor Author

lpinca commented Nov 27, 2018

I wonder if it's possible to upgrade to marked@0.5.2 instead, it would be better.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 82.204% when pulling 4716ec1 on lpinca:use/tarball-url into a47a4b8 on Rebilly:master.

@RomanHotsiy
Copy link
Member

Sorry for the long reply
see #734

@RomanHotsiy RomanHotsiy closed this Dec 6, 2018
@lpinca
Copy link
Contributor Author

lpinca commented Dec 6, 2018

Ok, can we use a tarball url in the meanwhile with your latest fix to marked?

@lpinca
Copy link
Contributor Author

lpinca commented Dec 6, 2018

I mean do they have an ETA for the next release? If not it might makes sense.

@lpinca lpinca deleted the use/tarball-url branch December 6, 2018 13:28
@RomanHotsiy
Copy link
Member

If it blocks you I am ok to updating to 0.5.2.

@lpinca
Copy link
Contributor Author

lpinca commented Dec 6, 2018

It would be great. It's not strictly a blocker but some of my coworkers are relying on horrible hacks due to this git dep :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants