Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use pytest < 7 because of conflict with pytest-cases #1138

Merged
merged 3 commits into from Feb 4, 2022

Conversation

bhazelton
Copy link
Member

@bhazelton bhazelton commented Feb 4, 2022

Description

Pin pytest < 7. This is a temporary fix for pytest-cases not being compatible with pytest 7.

I also added pytest-xdist for the external tests because they are now a limiting factor. Turns out it didn't help much, so I can remove it or leave it 🤷‍♀️ .

Motivation and Context

The conflict is being tracked here: smarie/python-pytest-cases#251
When it's fixed, we should require a newer version of pytest-cases and remove this pytest pin.

Types of changes

  • Build or continuous integration change

Checklist:

Build or continuous integration change checklist:

  • If required or optional dependencies have changed (including version numbers), I have updated the readme to reflect this.
  • If this is a new CI setup, I have added the associated badge to the readme and to references/make_index.py (if appropriate).

Temporary fix for pytest-cases not being compatible with pytest 7
@codecov
Copy link

codecov bot commented Feb 4, 2022

Codecov Report

Merging #1138 (1391eaf) into main (1d3959b) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1138   +/-   ##
=======================================
  Coverage   99.83%   99.83%           
=======================================
  Files          31       31           
  Lines       15387    15387           
=======================================
  Hits        15361    15361           
  Misses         26       26           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d3959b...1391eaf. Read the comment docs.

Copy link
Member

@mkolopanis mkolopanis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me. Let's revisit this once that issue is fixed.

@mkolopanis mkolopanis merged commit f2b60f7 into main Feb 4, 2022
@mkolopanis mkolopanis deleted the pin_pytest_version branch February 4, 2022 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants