Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase version requirement for pytest-cases, unpin pytest #1140

Merged
merged 2 commits into from
Feb 8, 2022

Conversation

bhazelton
Copy link
Member

@bhazelton bhazelton commented Feb 8, 2022

Description

Require a higher version of pytest-cases to fix an incompatibility with pytest>=7. Undo the pinning of pytest done in #1138.

Also fix the import of readsav from scipy to address new DeprecationWarning.

Motivation and Context

see #1138.

Types of changes

  • Build or continuous integration change

Checklist:

Build or continuous integration change checklist:

  • If required or optional dependencies have changed (including version numbers), I have updated the readme to reflect this.

@codecov
Copy link

codecov bot commented Feb 8, 2022

Codecov Report

Merging #1140 (58ef744) into main (f2b60f7) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1140   +/-   ##
=======================================
  Coverage   99.83%   99.83%           
=======================================
  Files          31       31           
  Lines       15387    15387           
=======================================
  Hits        15361    15361           
  Misses         26       26           
Impacted Files Coverage Δ
pyuvdata/uvcal/fhd_cal.py 100.00% <100.00%> (ø)
pyuvdata/uvdata/fhd.py 99.66% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f2b60f7...58ef744. Read the comment docs.

Copy link
Member

@plaplant plaplant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks @bhazelton!

@plaplant plaplant merged commit bf4788f into main Feb 8, 2022
@plaplant plaplant deleted the use_new_pytest-cases branch February 8, 2022 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants