Default init plugin was not properly raising when called with an invalid optimization level
#12170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
--- Co-authored-by: Evgenii Zheltonozhskii <zheltonozhskiy@gmail.com>
1ucian0
added
stable backport potential
|
One or more of the the following people are requested to review this:
|
Pull Request Test Coverage Report for Build 8661412596Details
💛 - Coveralls |
jakelishman
reviewed
Apr 11, 2024
|
I always thought that changelog was complete while reno is more "user facing". The bug is probably very hard to trigger by accident. Adding it in 2411f34 . |
mtreinish
approved these changes
Apr 12, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Apr 13, 2024
…valid optimization level (#12170) (#12174) * Raise instead of return. --- Co-authored-by: Evgenii Zheltonozhskii <zheltonozhskiy@gmail.com> * link * reno --------- Co-authored-by: Evgenii Zheltonozhskii <zheltonozhskiy@gmail.com> (cherry picked from commit e0be97c) Co-authored-by: Luciano Bello <bel@zurich.ibm.com>
|
@Mergifyio backport stable/0.46 |
✅ Backports have been created
|
github-merge-queue bot
pushed a commit
that referenced
this pull request
Apr 14, 2024
…valid optimization level (#12170) (#12175) * Raise instead of return. --- Co-authored-by: Evgenii Zheltonozhskii <zheltonozhskiy@gmail.com> * link * reno --------- Co-authored-by: Evgenii Zheltonozhskii <zheltonozhskiy@gmail.com> (cherry picked from commit e0be97c) Co-authored-by: Luciano Bello <bel@zurich.ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While @Randl was working on extending types in the
qiskit.transpilemodule, he found a bug in which the defaultinitplugin was not properly raising when called with an invalid optimization level. Thanks @Randl !