Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default init plugin was not properly raising when called with an invalid optimization level (backport #12170) #12174

Merged
merged 1 commit into from
Apr 13, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Apr 12, 2024

While @Randl was working on extending types in the qiskit.transpile module, he found a bug in which the default init plugin was not properly raising when called with an invalid optimization level. Thanks @Randl !


This is an automatic backport of pull request #12170 done by Mergify.

…valid optimization level (#12170)

* Raise instead of return.

---

Co-authored-by: Evgenii Zheltonozhskii <zheltonozhskiy@gmail.com>

* link

* reno

---------

Co-authored-by: Evgenii Zheltonozhskii <zheltonozhskiy@gmail.com>
(cherry picked from commit e0be97c)
@mergify mergify bot requested a review from a team as a code owner April 12, 2024 21:49
@qiskit-bot
Copy link
Collaborator

Thank you for opening a new pull request.

Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient.

While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone.

One or more of the the following people are requested to review this:

  • @Qiskit/terra-core

@github-actions github-actions bot added Changelog: Bugfix Include in the "Fixed" section of the changelog affects extended support This issue (also) affects extended support labels Apr 12, 2024
@github-actions github-actions bot added this to the 1.0.3 milestone Apr 12, 2024
@coveralls
Copy link

Pull Request Test Coverage Report for Build 8668344954

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.01%) to 89.32%

Files with Coverage Reduction New Missed Lines %
crates/qasm2/src/lex.rs 1 92.62%
Totals Coverage Status
Change from base Build 8598647194: 0.01%
Covered Lines: 58911
Relevant Lines: 65955

💛 - Coveralls

@mtreinish mtreinish added this pull request to the merge queue Apr 13, 2024
Merged via the queue into stable/1.0 with commit a83c99b Apr 13, 2024
14 checks passed
@mergify mergify bot deleted the mergify/bp/stable/1.0/pr-12170 branch April 13, 2024 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects extended support This issue (also) affects extended support Changelog: Bugfix Include in the "Fixed" section of the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants