Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove voice client when bot disconnects #1273

Merged
merged 2 commits into from Apr 18, 2022

Conversation

Dorukyum
Copy link
Member

Summary

Fixes #1049.

Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why
  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, typehinting, examples, ...)

@Dorukyum Dorukyum added this to the v2.0 milestone Apr 17, 2022
@Dorukyum Dorukyum added this to In progress in v2.0 via automation Apr 17, 2022
@Dorukyum Dorukyum self-assigned this Apr 17, 2022
krittick
krittick previously approved these changes Apr 17, 2022
Copy link
Member

@Middledot Middledot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Voice state updates only get dispatched for the client, ignoring other users

@Middledot Middledot merged commit 353bb56 into Pycord-Development:master Apr 18, 2022
v2.0 automation moved this from In progress to Done Apr 18, 2022
@Dorukyum Dorukyum deleted the remove-vc branch January 25, 2024 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
v2.0
  
Done
4 participants