Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disconnections Not Being Handled Correctly #1098

Closed
3 tasks done
KosmicAnomaly opened this issue Feb 28, 2022 · 3 comments
Closed
3 tasks done

Disconnections Not Being Handled Correctly #1098

KosmicAnomaly opened this issue Feb 28, 2022 · 3 comments
Labels
unconfirmed bug A bug report that needs triaging

Comments

@KosmicAnomaly
Copy link

KosmicAnomaly commented Feb 28, 2022

Summary

Pycord does not properly handle when a bot is manually disconnected from a voice channel, resulting in following attempts at connecting failing.

Reproduction Steps

Connect your bot to a voice channel
Manually disconnect it from within the discord client
Try to reconnect it
ClientException

Minimal Reproducible Code

No response

Expected Results

Pycord should automatically handle any disconnections within the library by fully disconnecting the voice client. The only time that a bot should need to handle voice connections is when it wants to move to a new voice channel, connect to a voice channel, or disconnect from a voice channel. It should not need to update if it is moved/disconnected via client, or if its channel is deleted. That should be built into pycord imo (and I think most of it already is)

Actual Results

Users have to come up with ways to detect and handle when their bots are disconnected unexpectedly, which isn't always easy/obvious

Intents

All

System Information

  • Python v3.10.2-final
  • py-cord v2.0.0-beta
    • py-cord pkg_resources: v2.0.0b1
  • aiohttp v3.8.1
  • system info: Windows 10 10.0.22000

Checklist

  • I have searched the open issues for duplicates.
  • I have shown the entire traceback, if possible.
  • I have removed my token from display, if visible.

Additional Context

No response

@KosmicAnomaly KosmicAnomaly added the unconfirmed bug A bug report that needs triaging label Feb 28, 2022
@Middledot
Copy link
Member

Can you provide a code example because I can't seem to reproduce

@Dorukyum
Copy link
Member

@KosmicAnomaly can you share the minimal reproducible code and check if this is still an issue?

@Dorukyum
Copy link
Member

Fixed in #1273.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
unconfirmed bug A bug report that needs triaging
Projects
None yet
Development

No branches or pull requests

3 participants