Add library-level enforcement of component field limits #1065
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krittick
added
priority: medium
16 tasks
# Conflicts: # discord/ui/input_text.py
7 tasks
|
What's the state of this |
|
Make that tomorrow, got too busy with work today. |
move modal title and custom_id attributes to properties
|
This is ready for review. Pretty sure I included all of the component limits, but let me know if I missed any. |
krittick
added
status: awaiting review
krittick
changed the title
Lulalaby
previously approved these changes
Apr 13, 2022
Dorukyum
reviewed
Apr 17, 2022
Lulalaby
previously approved these changes
Apr 17, 2022
Dorukyum
previously requested changes
Apr 18, 2022
Co-authored-by: Dorukyum <53639936+Dorukyum@users.noreply.github.com>
Co-authored-by: Dorukyum <53639936+Dorukyum@users.noreply.github.com>
Dorukyum
approved these changes
Apr 18, 2022
|
Looks good |
I do know math, I promise. Usually. |
Lulalaby
approved these changes
Apr 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
WIP, still needs robust testing
This adds library-level enforcement of limits on component fields, such as min/max values, label/placeholder lengths, and others. This helps reduce the chances of sending invalid data to the API.
Checklist
type: ignorecomments were used, a comment is also left explaining why