Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document Modal and Embed Parameter Limits #1247

Merged
merged 3 commits into from Apr 17, 2022
Merged

Document Modal and Embed Parameter Limits #1247

merged 3 commits into from Apr 17, 2022

Conversation

Ombucha
Copy link
Contributor

@Ombucha Ombucha commented Apr 10, 2022

Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why
  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, typehinting, examples, ...)

@krittick
Copy link
Contributor

This looks good, will need to wait for #1181 and #1065 to be merged first though.

Lulalaby
Lulalaby approved these changes Apr 11, 2022
View reviewed changes
Copy link
Member

@Lulalaby Lulalaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait for previous PRs

@Lulalaby Lulalaby merged commit 7b2e527 into Pycord-Development:master Apr 17, 2022
@Ombucha Ombucha deleted the patch-1 branch April 20, 2022 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lulalaby Lulalaby Lulalaby approved these changes

@Dorukyum Dorukyum Dorukyum approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Ombucha @krittick @Lulalaby @Dorukyum