Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use stable Rust for code coverage now that Rust 1.60 was released. #316

Merged
merged 1 commit into from Apr 14, 2022

Conversation

adamreichold
Copy link
Member

No description provided.

Copy link
Member

@davidhewitt davidhewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@adamreichold
Copy link
Member Author

Hhhmmm, looks like we will be unable to use without another point release of PyO3 remove those attributes. Might be a useful thing to do since other downstream crates might want to do the same?

image

@adamreichold
Copy link
Member Author

(Personally, I would also be glad if PyO3/pyo3#2279 were to become part of a PyO3 0.16.x point release.)

@davidhewitt
Copy link
Member

Hhhmmm, looks like we will be unable to use without another point release of PyO3 remove those attributes. Might be a useful thing to do since other downstream crates might want to do the same?

Oh, interesting. Yes I guess let's put together a 0.16.4 release.

@adamreichold adamreichold merged commit 4454e04 into main Apr 14, 2022
@adamreichold adamreichold deleted the stable-coverage branch April 14, 2022 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants