Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release: 0.16.4 #2290

Merged
merged 1 commit into from Apr 14, 2022
Merged

release: 0.16.4 #2290

merged 1 commit into from Apr 14, 2022

Conversation

adamreichold
Copy link
Member

I added a changelog entry for the coverage change because PyO3/rust-numpy#316 revealed that this also affects downstream crates depending on PyO3.

@davidhewitt Hopefully, this reduces the busy work for you a bit.

@davidhewitt
Copy link
Member

Thanks, it would be cool to add #2263 to this too

@adamreichold
Copy link
Member Author

Thanks, it would be cool to add #2263 to this too

Yes, I think that would make sense. Will rebase when that PR is merged.

@adamreichold
Copy link
Member Author

adamreichold commented Apr 10, 2022

@davidhewitt Keeping with the theme of reducing busy work, I tried drafting a GitHub release for you to review before publishing. Is there a command or script you use to generate the list of contributors?

@davidhewitt
Copy link
Member

Thanks!

No script; I just use the GitHub UI v0.16.3...HEAD

Every time I do it I think I should write a script and then never find the time 😂

@adamreichold
Copy link
Member Author

Every time I do it I think I should write a script and then never find the time joy

https://gist.github.com/adamreichold/b62493c129a55c0929b742990acb4185 appears to work. If it turns out to be helpful, maybe it can get a more permanent place of residence (and some amenities like error checking).

@davidhewitt
Copy link
Member

Nice! Yes I think it's fine to commit it somewhere to the repo.

@adamreichold
Copy link
Member Author

Rebased and updated the draft release.

@davidhewitt
Copy link
Member

Thanks! I didn't push this yesterday in the end because I wanted to wait until after 0.15.2 published. I couldn't remember if I pushed this and then 0.15.2 whether crates.io would list 0.16.4 or 0.15.2 as the latest version.

@davidhewitt
Copy link
Member

Force-pushed to update the date.

@davidhewitt
Copy link
Member

Rebased a final time to pick up #2293

@davidhewitt
Copy link
Member

Release is live. Thanks again @adamreichold for all the work writing fixes, reviewing, and preparing this release 👍

@davidhewitt davidhewitt merged commit 34ec0e8 into main Apr 14, 2022
@adamreichold adamreichold deleted the release-0.16.4 branch April 14, 2022 18:26
@adamreichold
Copy link
Member Author

I fear we might have regressed w.r.t. finding the Python interpreter: https://github.com/PyO3/rust-numpy/runs/6029114285?check_suite_focus=true

@adamreichold
Copy link
Member Author

It might also be Maturin, because the part where

  🔗 Found pyo3 bindings with abi3 support for Python ≥ 3.7

seems wrong as the crate does not use the stable ABI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants