Add PyTzInfoAccess #2263
Merged
Add PyTzInfoAccess #2263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pickfire
force-pushed
the
pytzinfoaccess
branch
from
fa4517f
to
bcbd4ae
Compare
pickfire
commented
Mar 31, 2022
davidhewitt
reviewed
Apr 10, 2022
pickfire
force-pushed
the
pytzinfoaccess
branch
2 times, most recently
from
0efd02b
to
e7326d2
Compare
Merged
davidhewitt
reviewed
Apr 11, 2022
pickfire
force-pushed
the
pytzinfoaccess
branch
from
e7326d2
to
bceacfd
Compare
davidhewitt
reviewed
Apr 11, 2022
pickfire
force-pushed
the
pytzinfoaccess
branch
from
bceacfd
to
67bfdc2
Compare
|
@pickfire You need to resolve conflicts otherwise CI won't run. |
pickfire
force-pushed
the
pytzinfoaccess
branch
from
67bfdc2
to
a1f97f1
Compare
… in datetime test.
adamreichold
force-pushed
the
pytzinfoaccess
branch
from
23f0c10
to
0d0089e
Compare
There was a problem hiding this comment.
@davidhewitt I think this is good to merge now. Do you concur? If so, I'll merge and rebase the 0.16.4 release branch.
adamreichold
approved these changes
Apr 13, 2022
|
That would be great; thanks & I'll put the release live tonight 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to pyo3!
Please consider adding the following to your pull request:
PyO3's CI pipeline will check your pull request. To run its tests
locally, you can run
cargo xtask ci. See its documentationhere.
As discussed in #1588 (comment)