PySequence: use usize everywhere, fix in-place methods #1803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(I guess this needs to wait for #1802) |
birkenfeld
force-pushed
the
pysequence_usize
branch
from
279c22c
to
4f1e4d6
Compare
birkenfeld
added a commit
that referenced
this pull request
Aug 18, 2021
birkenfeld
force-pushed
the
pysequence_usize
branch
from
4f1e4d6
to
af81591
Compare
birkenfeld
changed the title
|
👍 this is looking good! It looks like there's a few |
a) not leak a reference b) correctly return the result, since for immutable types `self` is not actually mutated in place
birkenfeld
force-pushed
the
pysequence_usize
branch
from
af81591
to
0ab1aca
Compare
|
Sure. |
birkenfeld
force-pushed
the
pysequence_usize
branch
from
0ab1aca
to
ead86bd
Compare
davidhewitt
approved these changes
Aug 24, 2021
There was a problem hiding this comment.
Looks good to me, thanks for the new tests!
I guess still to be added for #1667 is to add the impl std::ops::Index implementations, and maybe also an entry in the migration guide.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.