sequence: tidy up implementation #1826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
birkenfeld
approved these changes
Aug 24, 2021
There was a problem hiding this comment.
BTW, when I looked at the code earlier I got a bit worried about returning &PySequence here: there is no obligation for the functions on the (C)Python side to return something usable as a sequence.
But since PySequence is just an abstract API, not a concrete object type, there is no unsoundness, and it makes sense to keep the convenience on the Rust side.
|
👍 agreed, as I've understood it, calling the pysequence APIs with an incompatible object will just raise an error. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just noticed this while reviewing #1803