Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wemake has 80 chars hard limit, not 79 #2241

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

wemake has 80 chars hard limit, not 79 #2241

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1593706
`wemake` has 80 chars hard limit, not 79
sobolevn Feb 28, 2024
b553962
Update test_wemake.py
sobolevn Feb 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion isort/profiles.py
View file
Open in desktop
Expand Up @@ -61,7 +61,7 @@
"multi_line_output": 3,
"include_trailing_comma": True,
"use_parentheses": True,
"line_length": 79,
"line_length": 80,
}
appnexus = {
**black,
Expand Down
16 changes: 14 additions & 2 deletions tests/unit/profiles/test_wemake.py
View file
Open in desktop
Expand Up @@ -88,10 +88,22 @@ class _ClassVisitor(ast.NodeVisitor): ...


def test_wemake_snippet_four():
"""80 line length should be fixed"""
"""80 line length should not be fixed"""
wemake_isort_test(
"""
from typing import Iterable, Iterator, Optional, Sequence, Tuple, TypeVar, Union
""",
"""
from typing import Iterable, Iterator, Optional, Sequence, Tuple, TypeVar, Union
""",
)


def test_wemake_snippet_five():
"""81 line length should be fixed"""
wemake_isort_test(
"""
from typing import Iterable, Iterator, Optional, Sequence, Tuple, TypeVar, Union1
""",
"""
from typing import (
Expand All @@ -101,7 +113,7 @@ def test_wemake_snippet_four():
Sequence,
Tuple,
TypeVar,
Union,
Union1,
)
""",
)