Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wemake has 80 chars hard limit, not 79 #2241

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

wemake has 80 chars hard limit, not 79 #2241

wants to merge 2 commits into from

Conversation

sobolevn
Copy link
Member

@sobolevn sobolevn commented Feb 28, 2024 •
edited

@codecov Codecov
Copy link

codecov bot commented Feb 28, 2024

Codecov Report

Merging #2241 (b553962) into main (7de1829) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #2241   +/-   ##
=======================================
  Coverage   99.15%   99.15%           
=======================================
  Files          39       39           
  Lines        3091     3091           
  Branches      748      748           
=======================================
  Hits         3065     3065           
  Misses         15       15           
  Partials       11       11

@sobolevn
Copy link
Member Author

Lint failure is unrelated:

 +==============================================================================+
 VULNERABILITIES FOUND 
+==============================================================================+

-> Vulnerability found in bandit version 1.7.6
   Vulnerability ID: 64484
   Affected spec: <1.7.7
   ADVISORY: Bandit 1.7.7 identifies the str.replace method as a
   potential risk for SQL injection because it can be misused in constructing...
   PVE-2024-64484
   For more information, please visit
   https://data.safetycli.com/v/64484/f17


-> Vulnerability found in mkdocs-material version 8.5.4
   Vulnerability ID: 59587
   This vulnerability is being ignored.
   For more information, please visit
   https://data.safetycli.com/v/59587/f17


-> Vulnerability found in py version 1.11.0
   Vulnerability ID: 51457
   This vulnerability is being ignored.
   For more information, please visit
   https://data.safetycli.com/v/51457/f17

 Scan was completed. 1 vulnerability was found. 2 vulnerabilities from 2 
 packages were ignored.

@sobolevn
Copy link
Member Author

After fixing it, wemake-python-styleguide builds work once again: wemake-services/wemake-python-styleguide#2864 🎉 👍

@sobolevn
Copy link
Member Author

sobolevn commented Mar 4, 2024

@staticdev friendly ping :)

@sobolevn
Copy link
Member Author

@timothycrosley looks like this project needs an extra pair of eyes :)
I can volunteer to do some review and maintaince work for isort.
I know a thing or two about Python

My email is in my profile, just in case.

@sobolevn

This comment was marked as spam.

Sign in to view
sobolevn added a commit to sobolevn/isort that referenced this pull request Apr 14, 2024
@sobolevn
Ignore bandit's CVE reported by safety
9f7b56e 
It is a dev-dependency and there's no real vulnerability.
This is why a job in my CI fails: PyCQA#2241

Link to CVE: https://data.safetycli.com/v/64484/f17

Or you can bump `bandit` to 1.7.8: https://pypi.org/project/bandit/1.7.8/
@sobolevn sobolevn mentioned this pull request Apr 14, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@sobolevn