Commits on Apr 17, 2023

1. Upgrade the isort version to use with pre-commit …

   Indeed version v1.5.0 of poetry-core introduced some additional validations
   which means that all dependencies specified in pyproject.toml file
   under [tool.poetry.extras], must also be specified in the main
   dependencies’ section [tool.poetry.dependencies].
   
   After this poetry release, isort installations from source have started
   failing given that an older pyproject.toml file of isort was specifying
   pip-shims library in extras section, but not in tool.poetry.dependencies.
   Since isort did not explicitly specify a pin for poetry-core, it
   automatically picked up the new poetry release which was incompatible
   with isort‘s pyproject.toml file.
   
   ```
   pre-commit run --all-files
   [INFO] Initializing environment for https://github.com/pycqa/isort.
   [INFO] Installing environment for https://github.com/pycqa/isort.
   [INFO] Once installed this environment will be reused.
   [INFO] This may take a few minutes...
   An unexpected error has occurred: CalledProcessError: command: ('/home/hberaud/.cache/pre-commit/repok8c4fobi/py_env-python3/bin/python', '-mpip', 'install', '.')
   return code: 1
   stdout:
       Processing /home/hberaud/.cache/pre-commit/repok8c4fobi
         Installing build dependencies: started
         Installing build dependencies: finished with status 'done'
         Getting requirements to build wheel: started
         Getting requirements to build wheel: finished with status 'done'
         Preparing metadata (pyproject.toml): started
         Preparing metadata (pyproject.toml): finished with status 'error'
   stderr:
         error: subprocess-exited-with-error
   
         × Preparing metadata (pyproject.toml) did not run successfully.
         │ exit code: 1
         ╰─> [14 lines of output]
             Traceback (most recent call last):
               File "/home/hberaud/.cache/pre-commit/repok8c4fobi/py_env-python3/lib/python3.10/site-packages/pip/_vendor/pyproject_hooks/_in_process/_in_process.py", line 353, in <module>
                 main()
               File "/home/hberaud/.cache/pre-commit/repok8c4fobi/py_env-python3/lib/python3.10/site-packages/pip/_vendor/pyproject_hooks/_in_process/_in_process.py", line 335, in main
                 json_out['return_val'] = hook(**hook_input['kwargs'])
               File "/home/hberaud/.cache/pre-commit/repok8c4fobi/py_env-python3/lib/python3.10/site-packages/pip/_vendor/pyproject_hooks/_in_process/_in_process.py", line 149, in prepare_metadata_for_build_wheel
                 return hook(metadata_directory, config_settings)
               File "/tmp/pip-build-env-vnuvfcd9/overlay/lib/python3.10/site-packages/poetry/core/masonry/api.py", line 40, in prepare_metadata_for_build_wheel
                 poetry = Factory().create_poetry(Path(".").resolve(), with_groups=False)
               File "/tmp/pip-build-env-vnuvfcd9/overlay/lib/python3.10/site-packages/poetry/core/factory.py", line 57, in create_poetry
                 raise RuntimeError("The Poetry configuration is invalid:\n" + message)
             RuntimeError: The Poetry configuration is invalid:
               - [extras.pipfile_deprecated_finder.2] 'pip-shims<=0.3.4' does not match '^[a-zA-Z-_.0-9]+$'
   
             [end of output]
   
         note: This error originates from a subprocess, and is likely not a problem with pip.
       error: metadata-generation-failed
   
       × Encountered error while generating package metadata.
       ╰─> See above for output.
   ```
   
   This upgraded version contains the fix and work well with pre-commit.

   

   4383 committed Apr 17, 2023
   Configuration menu

   • View commit details
   • Copy full SHA for fd75d91
   • Browse repository at this point

   Copy the full SHA

   fd75d91 View commit details

   Browse the repository at this point in the history