Upgrade the isort version to use with pre-commit #2122
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Indeed version v1.5.0 of poetry-core introduced some additional validations which means that all dependencies specified in pyproject.toml file under [tool.poetry.extras], must also be specified in the main dependencies’ section [tool.poetry.dependencies].
After this poetry release, isort installations from source have started failing given that an older pyproject.toml file of isort was specifying pip-shims library in extras section, but not in tool.poetry.dependencies. Since isort did not explicitly specify a pin for poetry-core, it automatically picked up the new poetry release which was incompatible with isort‘s pyproject.toml file.
This upgraded version contains the fix and work well with pre-commit.