New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Web IDL language support #1102
Closed
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| Prism.languages.webidl = Prism.languages.extend('c', { | ||
| 'keyword': /\b(any|attribute|boolean|byte|ByteString|callback|const|deleter|dictionary|DOMString|double|enum|float|FrozenArray|getter|identifier|implements|Infinity|inherit|integer|interface|iterable|legacycaller|long|maplike|namespace|NaN|null|object|octet|optional|or|other|partial|readonly|required|sequence|serializer|setlike|setter|short|static|string|stringifier|typedef|unrestricted|unsigned|USVString|void)\b/, | ||
| 'boolean': /\b(true|false)\b/, | ||
| 'operator': /-|:|=|\?|\*|\// | ||
| }); | ||
|
|
||
| Prism.languages.insertBefore('webidl', 'keyword', { | ||
| 'class-name': { | ||
| pattern: /(class\s+)[a-z0-9_]+/i, | ||
| lookbehind: true | ||
| } | ||
| }); | ||
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,37 @@ | ||
| <h1>Web IDL</h1> | ||
| <p>To use this language, use the class "language-webidl".</p> | ||
|
|
||
| <h2>Strings</h2> | ||
| <pre><code>"foo \"bar\" baz" | ||
| 'foo \'bar\' baz' | ||
| "Multi-line strings ending with a \ | ||
| are supported too."</code></pre> | ||
|
|
||
| <h2>Booleans</h2> | ||
| <pre><code>true; | ||
| false;</code></pre> | ||
|
|
||
| <h2>Full example</h2> | ||
| <pre><code>interface Paint { }; | ||
|
|
||
| interface SolidColor : Paint { | ||
| attribute double red; | ||
| attribute double green; | ||
| attribute double blue; | ||
| }; | ||
|
|
||
| interface Pattern : Paint { | ||
| attribute DOMString imageURL; | ||
| }; | ||
|
|
||
| [Constructor] | ||
| interface GraphicalWindow { | ||
| readonly attribute unsigned long width; | ||
| readonly attribute unsigned long height; | ||
|
|
||
| attribute Paint currentPaint; | ||
|
|
||
| void drawRectangle(double x, double y, double width, double height); | ||
|
|
||
| void drawText(double x, double y, DOMString text); | ||
| };</code></pre> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| true | ||
| false | ||
|
|
||
| ---------------------------------------------------- | ||
|
|
||
| [ | ||
| ["boolean", "true"], | ||
| ["boolean", "false"] | ||
| ] | ||
|
|
||
| ---------------------------------------------------- | ||
|
|
||
| Checks for booleans. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,107 @@ | ||
| any | ||
| attribute | ||
| boolean | ||
| byte | ||
| ByteString | ||
| callback | ||
| const | ||
| deleter | ||
| dictionary | ||
| DOMString | ||
| double | ||
| enum | ||
| float | ||
| FrozenArray | ||
| getter | ||
| identifier | ||
| implements | ||
| Infinity | ||
| inherit | ||
| integer | ||
| interface | ||
| iterable | ||
| legacycaller | ||
| long | ||
| maplike | ||
| namespace | ||
| NaN | ||
| null | ||
| object | ||
| octet | ||
| optional | ||
| or | ||
| other | ||
| partial | ||
| readonly | ||
| required | ||
| sequence | ||
| serializer | ||
| setlike | ||
| setter | ||
| short | ||
| static | ||
| string | ||
| stringifier | ||
| typedef | ||
| unrestricted | ||
| unsigned | ||
| USVString | ||
| void | ||
|
|
||
| ---------------------------------------------------- | ||
|
|
||
| [ | ||
| ["keyword", "any"], | ||
| ["keyword", "attribute"], | ||
| ["keyword", "boolean"], | ||
| ["keyword", "byte"], | ||
| ["keyword", "ByteString"], | ||
| ["keyword", "callback"], | ||
| ["keyword", "const"], | ||
| ["keyword", "deleter"], | ||
| ["keyword", "dictionary"], | ||
| ["keyword", "DOMString"], | ||
| ["keyword", "double"], | ||
| ["keyword", "enum"], | ||
| ["keyword", "float"], | ||
| ["keyword", "FrozenArray"], | ||
| ["keyword", "getter"], | ||
| ["keyword", "identifier"], | ||
| ["keyword", "implements"], | ||
| ["keyword", "Infinity"], | ||
| ["keyword", "inherit"], | ||
| ["keyword", "integer"], | ||
| ["keyword", "interface"], | ||
| ["keyword", "iterable"], | ||
| ["keyword", "legacycaller"], | ||
| ["keyword", "long"], | ||
| ["keyword", "maplike"], | ||
| ["keyword", "namespace"], | ||
| ["keyword", "NaN"], | ||
| ["keyword", "null"], | ||
| ["keyword", "object"], | ||
| ["keyword", "octet"], | ||
| ["keyword", "optional"], | ||
| ["keyword", "or"], | ||
| ["keyword", "other"], | ||
| ["keyword", "partial"], | ||
| ["keyword", "readonly"], | ||
| ["keyword", "required"], | ||
| ["keyword", "sequence"], | ||
| ["keyword", "serializer"], | ||
| ["keyword", "setlike"], | ||
| ["keyword", "setter"], | ||
| ["keyword", "short"], | ||
| ["keyword", "static"], | ||
| ["keyword", "string"], | ||
| ["keyword", "stringifier"], | ||
| ["keyword", "typedef"], | ||
| ["keyword", "unrestricted"], | ||
| ["keyword", "unsigned"], | ||
| ["keyword", "USVString"], | ||
| ["keyword", "void"], | ||
| ] | ||
|
|
||
| ---------------------------------------------------- | ||
|
|
||
| Checks for all keywords |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the point of calling
insertBeforefor webidl right after you've defined webidl?insertBeforeis used to modify existing languages, if you're defining a language yourself you don't need it, just put"class-name"in the object literal.Also, your dependencies list C-like, but here you seem to be extending C. These are two different language definitions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I copied the cpp implementation, so maybe there is something in the insertBefore code that it needed. Either way, I don't understand so I'm happy to do whatever.
As for the dependencies, you're right that it's not clear. WebIDL isn't technically C, C-like, or CPP. I figured it would be ok to extend from cpp though, since it does have fairly similar syntax.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just add the "class-name" token before the keyword token. There's no need for it to be separate. What the cpp language is doing is weird too, @zeitgeist87 what was the rationale?
As for the dependencies, I don't mind which one you inherit from, just be consistent between your code and the components declaration, otherwise people will get a download that doesn't work. Perhaps look over their examples to decide which of the three is closer to WebIDL?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@LeaVerou The
clanguage actually deletes theclass-nameproperty fromclike, so if you inherit fromcand you want to putclass-nameat a certain position, you have to useinsertBefore(). However if you inherit fromclike, you can directly addclass-nameto the language.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see. So the main blocker here is that @grorg needs to decide whether he's extending C, C++ or C-like. I think the latter is probably a better fit, but he knows WebIDL better.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the tips @LeaVerou and @zeitgeist87. I'll update the patch soon.
Hahahahaha. If only.