Add Web IDL language support #1102
Conversation
| pattern: /(class\s+)[a-z0-9_]+/i, | ||
| lookbehind: true | ||
| } | ||
| }); |
There was a problem hiding this comment.
What's the point of calling insertBefore for webidl right after you've defined webidl? insertBefore is used to modify existing languages, if you're defining a language yourself you don't need it, just put "class-name" in the object literal.
Also, your dependencies list C-like, but here you seem to be extending C. These are two different language definitions.
There was a problem hiding this comment.
I copied the cpp implementation, so maybe there is something in the insertBefore code that it needed. Either way, I don't understand so I'm happy to do whatever.
As for the dependencies, you're right that it's not clear. WebIDL isn't technically C, C-like, or CPP. I figured it would be ok to extend from cpp though, since it does have fairly similar syntax.
There was a problem hiding this comment.
Just add the "class-name" token before the keyword token. There's no need for it to be separate. What the cpp language is doing is weird too, @zeitgeist87 what was the rationale?
As for the dependencies, I don't mind which one you inherit from, just be consistent between your code and the components declaration, otherwise people will get a download that doesn't work. Perhaps look over their examples to decide which of the three is closer to WebIDL?
There was a problem hiding this comment.
@LeaVerou The c language actually deletes the class-name property from clike, so if you inherit from c and you want to put class-name at a certain position, you have to use insertBefore(). However if you inherit from clike, you can directly add class-name to the language.
There was a problem hiding this comment.
I see. So the main blocker here is that @grorg needs to decide whether he's extending C, C++ or C-like. I think the latter is probably a better fit, but he knows WebIDL better.
There was a problem hiding this comment.
Thanks for the tips @LeaVerou and @zeitgeist87. I'll update the patch soon.
he knows WebIDL better
Hahahahaha. If only.
|
I've added a few comments, though I'd wait for some more review from the other maintainers before merging. But I'm really excited about this! I assume you're using Prism in specs then? |
I was using it in some WebGPU stuff. Neither prism or highlight.js supported WebIDL. I decided prism was easier :) |
|
@grorg Are you able to make the changes suggested here? We'd love to land this! |
|
Yeah, thanks for poking me. I'll clean it up and post again soon. |
|
Closed in favor of #3107. |
Hi. This is my first attempt at adding a language. I'm not sure I got everything right - the examples page has this language greyed out, for example. It seems that it tries to load content from github?
I'm happy to change anything necessary.
WebIDL features not yet supported: extended attributes and predefined error/exception names.