Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use actions/setup-node@v2 to cache node_modules #216

Merged
merged 1 commit into from Aug 17, 2021
Merged

Use actions/setup-node@v2 to cache node_modules #216

merged 1 commit into from Aug 17, 2021

Conversation

Quetzacoalt91
Copy link
Contributor

@Quetzacoalt91 Quetzacoalt91 commented Jul 14, 2021 •
edited

Following https://twitter.com/mheap/status/1411390113230344197?s=20, this PR introduces npm cache in our JS wokflows.

This branch has been pushed on the main repo as I need to see the impact on the cache.

@Quetzacoalt91 Quetzacoalt91 added enhancement Type: Improvement VueJS Tech: VueJS labels Jul 14, 2021
@Quetzacoalt91 Quetzacoalt91 force-pushed the ci-cache-npm-deps branch 2 times, most recently from 8b93955 to da32e2f Compare July 14, 2021 10:36
@Quetzacoalt91 Quetzacoalt91 added the WIP Status: Work In Progress label Jul 14, 2021
@Quetzacoalt91
Copy link
Contributor Author

Quetzacoalt91 commented Jul 14, 2021 •
edited

Can't go further at the moment, as we can't specify a working directory to use when installing and building application.

We should keep a look at:

@Quetzacoalt91 Quetzacoalt91 marked this pull request as draft July 14, 2021 10:44
@Quetzacoalt91 Quetzacoalt91 force-pushed the ci-cache-npm-deps branch 2 times, most recently from 9fbb7fb to 4fd3196 Compare July 14, 2021 11:03
@amaury-hanser
Copy link
Contributor

@Quetzacoalt91 , looks like actions/setup-node#299 has been merged !

@Quetzacoalt91 Quetzacoalt91 force-pushed the ci-cache-npm-deps branch 2 times, most recently from f261c69 to e05e109 Compare August 16, 2021 15:51
@Quetzacoalt91 Quetzacoalt91 removed the WIP Status: Work In Progress label Aug 16, 2021
@Quetzacoalt91 Quetzacoalt91 marked this pull request as ready for review August 16, 2021 16:08
@Quetzacoalt91
Copy link
Contributor Author

Ready for review!

@Quetzacoalt91 Quetzacoalt91 merged commit f0269c9 into master Aug 17, 2021
@Quetzacoalt91 Quetzacoalt91 deleted the ci-cache-npm-deps branch August 17, 2021 13:32
@Quetzacoalt91 Quetzacoalt91 mentioned this pull request Aug 20, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement Type: Improvement VueJS Tech: VueJS
Projects
None yet
Milestone
No milestone
2 participants
@Quetzacoalt91 @amaury-hanser