Use actions/setup-node@v2 to cache node_modules

PrestaShopCorp · Aug 16, 2021 · f261c69 · f261c69
1 parent eb05618
commit f261c69
Show file tree

Hide file tree

Showing 4 changed files with 44 additions and 25 deletions.
diff --git a/.github/workflows/build-release.yml b/.github/workflows/build-release.yml
@@ -11,14 +11,18 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: Checkout
-        uses: actions/checkout@v2.0.0
+        uses: actions/checkout@v2
 
-      - name: Build JS dependencies
-        uses: PrestaShopCorp/github-action-build-js/12@v1.0
+      - uses: actions/setup-node@v2
         with:
-          cmd: npm
-          path: ./_dev
-
+          node-version: '14'
+          cache: npm
+          cache-dependency-path: '_dev/package-lock.json'
+
+      - name: Install & build
+        run: |
+          npm install
+          npm run build
 
       - name: Install dev composer dependencies
         run: composer install
@@ -33,7 +37,7 @@ jobs:
         uses: PrestaShopCorp/github-action-clean-before-deploy@v1.0
 
       - name: Create & upload artifact
-        uses: actions/upload-artifact@v1
+        uses: actions/upload-artifact@v2
         with:
           name: ${{ github.event.repository.name }}
           path: ../
diff --git a/.github/workflows/js.yml b/.github/workflows/js.yml
@@ -6,13 +6,18 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: Checkout
-        uses: actions/checkout@v2.0.0
+        uses: actions/checkout@v2
+
+      - uses: actions/setup-node@v2
+        with:
+          node-version: '14'
+          cache: npm
+          cache-dependency-path: '_dev/package-lock.json'
+
+      - run: npm install
 
       - name: Lint JS files
-        uses: PrestaShopCorp/github-action-lint-js/12@v1.0
-        with:
-          cmd: npm
-          path: ./_dev
+        run: npm run lint
 
   unit-tests:
     name: JS Unit tests
@@ -21,8 +26,13 @@ jobs:
       - name: Checkout
         uses: actions/checkout@v2
 
+      - uses: actions/setup-node@v2
+        with:
+          node-version: '14'
+          cache: npm
+          cache-dependency-path: '_dev/package-lock.json'
+
       - name: Install & run
         run: |
-          cd _dev
           npm install
           npm run test:unit
diff --git a/.github/workflows/php.yml b/.github/workflows/php.yml
@@ -6,7 +6,7 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: Checkout
-        uses: actions/checkout@v2.0.0
+        uses: actions/checkout@v2
 
       - name: PHP syntax checker 7.3
         uses: prestashop/github-action-php-lint/7.3@master
@@ -19,7 +19,7 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: Checkout
-        uses: actions/checkout@v2.0.0
+        uses: actions/checkout@v2
 
       - name: Run PHP-CS-Fixer
         uses: prestashopcorp/github-action-php-cs-fixer@master
@@ -32,7 +32,7 @@ jobs:
         presta-versions: ['1.7.7.0', 'latest']
     steps:
       - name: Checkout
-        uses: actions/checkout@v2.0.0
+        uses: actions/checkout@v2
 
       - name: Cache vendor folder
         uses: actions/cache@v1

diff --git a/.github/workflows/publish.yml b/.github/workflows/publish.yml
@@ -10,13 +10,18 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: Checkout
-        uses: actions/checkout@v2.0.0
+        uses: actions/checkout@v2
 
-      - name: Build JS dependencies
-        uses: PrestaShopCorp/github-action-build-js/12@v1.0
+      - uses: actions/setup-node@v2
         with:
-          cmd: npm
-          path: ./_dev
+          node-version: '14'
+          cache: npm
+          cache-dependency-path: '_dev/package-lock.json'
+
+      - name: Install & build
+        run: |
+          npm install
+          npm run build
 
       - name: Install composer dependencies
         run: composer install --no-dev -o
@@ -25,7 +30,7 @@ jobs:
         uses: PrestaShopCorp/github-action-clean-before-deploy@v1.0
 
       - name: Create & upload artifact
-        uses: actions/upload-artifact@v1
+        uses: actions/upload-artifact@v2
         with:
           name: ${{ github.event.repository.name }}
           path: ../
@@ -36,7 +41,7 @@ jobs:
     needs: build
     steps:
       - name: Download artifact
-        uses: actions/download-artifact@v1
+        uses: actions/download-artifact@v2
         with:
           name: ${{ github.event.repository.name }}
 
@@ -61,7 +66,7 @@ jobs:
     needs: build
     steps:
       - name: Download artifact
-        uses: actions/download-artifact@v1
+        uses: actions/download-artifact@v2
         with:
           name: ${{ github.event.repository.name }}
 
@@ -101,7 +106,7 @@ jobs:
     if: github.event.release.prerelease == false
     steps:
       - name: Checkout
-        uses: actions/checkout@v2.0.0
+        uses: actions/checkout@v2
 
       - name: Download release asset
         uses: dsaltares/fetch-gh-release-asset@0.0.5