Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes tests for httpx 0.23.2 #8032

Merged
merged 1 commit into from Jan 3, 2023
Merged

Fixes tests for httpx 0.23.2 #8032

merged 1 commit into from Jan 3, 2023

Conversation

desertaxle
Copy link
Member

@desertaxle desertaxle commented Jan 3, 2023

httpx started throwing errors in 0.23.2 for UUIDs passed into params. This PR fixes tests that started failing due to that change.

Example

Checklist

  • This pull request references any related issue by including "closes <link to issue>"
    • If no issue exists and your change is not a small fix, please create an issue first.
  • This pull request includes tests or only affects documentation.
  • This pull request includes a label categorizing the change e.g. fix, feature, enhancement

@desertaxle desertaxle added the maintenance Chores and other work not directly related to the product label Jan 3, 2023
@netlify
Copy link

netlify bot commented Jan 3, 2023

Deploy Preview for prefect-orion ready!

Name Link
🔨 Latest commit 2612dfb
🔍 Latest deploy log https://app.netlify.com/sites/prefect-orion/deploys/63b42a0d55a2800008714f7d
😎 Deploy Preview https://deploy-preview-8032--prefect-orion.netlify.app/api-ref/prefect/client
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@zanieb
Copy link
Contributor

zanieb commented Jan 3, 2023

See encode/httpx#2523 for the cause.

Should we release a version of Prefect without this fix that adds an HTTPX upper bound then release another with the fix (with the upper bound removed) so our users are less likely to encounter version compatibility errors? It might not be worth it on our release cadence.

@zanieb zanieb merged commit 20bd17c into main Jan 3, 2023
@zanieb zanieb deleted the fix-httpx-test-failures branch January 3, 2023 17:12
github-actions bot pushed a commit that referenced this pull request Jan 4, 2023
github-actions bot pushed a commit that referenced this pull request Jan 4, 2023
masonmenges pushed a commit that referenced this pull request Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Chores and other work not directly related to the product
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants