Use worker_pool_name and worker_pool_queue_name in deployment API endpoints.
#8031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for prefect-orion ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
desertaxle
added
the
maintenance
desertaxle
changed the title
worker_pool_name and worker_pool_queue_name from deployment API endpoints.worker_pool_name and worker_pool_queue_name in deployment API endpoints.
cicdw
requested changes
Jan 4, 2023
3 tasks
Replaced with worker_pool_queue_name and worker_pool_name
desertaxle
force-pushed
the
wp-and-wpq-names-deployments-api
branch
from
c51e1d8
to
f0a0acf
Compare
peytonrunyan
approved these changes
Jan 6, 2023
cicdw
approved these changes
Jan 6, 2023
masonmenges
pushed a commit
that referenced
this pull request
Jan 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates deployment API endpoints to return
worker_pool_nameandworker_pool_queue_nameto better align with worker pool and worker pool queue GET endpoints that use names.Updates deployment create and update API endpoints to accept
worker_pool_nameandworker_pool_queue_nameto eliminate need for clients to interact with IDs for worker pools or worker pool queues.See #8012 for a similar implementation for flow runs.
Example
Checklist
<link to issue>"fix,feature,enhancement