#1061 replace SocketUtils with TestSocketUtils #1062
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klu2
force-pushed
the
1061/test-socket-utils
branch
from
9e238d5
to
c4eae9f
Compare
ijusti
previously approved these changes
Nov 28, 2022
|
@klu2 Please rebase your branch. |
Fameing
previously approved these changes
Dec 2, 2022
klu2
force-pushed
the
1061/test-socket-utils
branch
from
c4eae9f
to
f522399
Compare
klu2
force-pushed
the
1061/test-socket-utils
branch
from
f522399
to
d180c8f
Compare
… Spring Boot and Spring Cloud
klu2
force-pushed
the
1061/test-socket-utils
branch
from
d180c8f
to
93179f2
Compare
Fameing
approved these changes
Dec 6, 2022
|
@Fameing Was this change consciously reverted again in 067eb0e? The release notes for 2.2.13 claim that the release includes this change, but it was reverted again in #1074. Thanks for your effort and sharing this project! |
thammerl
added a commit
to thammerl/testcontainers-spring-boot
that referenced
this pull request
Dec 19, 2022
- Fixes PlaytikaOSS#1061 (again). - Regression introduced with PlaytikaOSS#1074. - PlaytikaOSS#1044 initially fixed PlaytikaOSS#1043 by changing the minimum port passed to `SocketUtils` from 1000 to 1025. PlaytikaOSS#1062 then changed the fix and additionally resolved PlaytikaOSS#1061 by replacing `SocketUtils` with `TestSocketUtils` from spring-test. PlaytikaOSS#1074 then reverted this change reintroducing the dependency to `SocketUtils`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #1061 and also updates to the latest 2.x versions of Spring Boot and Spring Cloud