#1061 Replace SocketUtils with TestSocketUtils #1082
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fixes PlaytikaOSS#1061 (again). - Regression introduced with PlaytikaOSS#1074. - PlaytikaOSS#1044 initially fixed PlaytikaOSS#1043 by changing the minimum port passed to `SocketUtils` from 1000 to 1025. PlaytikaOSS#1062 then changed the fix and additionally resolved PlaytikaOSS#1061 by replacing `SocketUtils` with `TestSocketUtils` from spring-test. PlaytikaOSS#1074 then reverted this change reintroducing the dependency to `SocketUtils`.
|
fixed in #1083 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SocketUtilsfrom 1000 to 1025. #1061 replace SocketUtils with TestSocketUtils #1062 then changed the fix and additionally resolved Remove the dependency to org.springframework.util.SocketUtils #1061 by replacingSocketUtilswithTestSocketUtilsfrom spring-test. Fix findAvailableTcpPort for redis from 1025 to 50000 #1074 then reverted this change reintroducing the dependency toSocketUtils.