Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: SectionList support (without stickyHeaders for now) #201

Merged
merged 5 commits into from
Oct 3, 2021
Merged

feat: SectionList support (without stickyHeaders for now) #201

merged 5 commits into from
Oct 3, 2021

Conversation

alexco2
Copy link
Contributor

@alexco2 alexco2 commented Oct 1, 2021

Added SectionList Support. Also updated documentation and added example tab with a SectionList.
As we know from #136 stickyHeaders cause a problem. This issue also applies to SectionList. I played around with paddingTop, but couldn´t solve the issue.
I also upgraded Expo to v42 and reanimated to v2.2.2.

removed disabled stickySectionHeaders to be in line with FlatLists approach to stickyHeaders issue
@alexco2 alexco2 mentioned this pull request Oct 1, 2021
@alexco2
Copy link
Contributor Author

alexco2 commented Oct 1, 2021

I initially wanted to create a seperate pull request for the reanimated and Expo update, but it looks like I added the commit to this pull request. Sorry, I´m still a bit new to git. Anyway, this pr would close this issue: #164

@alexco2 alexco2 changed the title Added SectionList Support Added SectionList Support and updated Expo and Reanimated Oct 1, 2021
@PedroBern
Copy link
Owner

PedroBern commented Oct 2, 2021

hi @alexco2 thanks for the PR, appreciate the bump on expo and reanimated 🙌 But it has a bug (don't know if there are more bugs though, I stopped testing after this due to time constraints on my end):

bug.mp4

@alexco2
Copy link
Contributor Author

alexco2 commented Oct 2, 2021

Added SectionList Support. Also updated documentation and added example tab with a SectionList.
As we know from #136 stickyHeaders cause a problem. This issue also applies to SectionList. I played around with paddingTop, but couldn´t solve the issue.
I also upgraded Expo to v42 and reanimated to v2.2.2.

Hi @PedroBern
Thank you for the quick reply. I've also noticed this bug. It's not a new one as it is the same one as in #136.
I tried fixing it but wasn't successful. Should it be disabled by default on iOS?

example/src/Shared/SectionContacts.tsx Outdated Show resolved Hide resolved
@PedroBern
Copy link
Owner

@alexco2 with the required review changes looks good to me 🚀 thanks for the PR 🎉

@andreialecu could you please review as well?

@PedroBern PedroBern linked an issue Oct 2, 2021 that may be closed by this pull request
@andreialecu
Copy link
Collaborator

I'll take a look tomorrow.

@andreialecu andreialecu changed the title Added SectionList Support and updated Expo and Reanimated feat: SectionList support (without stickyHeaders for now) Oct 3, 2021
@andreialecu andreialecu merged commit 1571a62 into PedroBern:main Oct 3, 2021
@andreialecu
Copy link
Collaborator

Released in 4.3.0 🚀

@alexco2
Copy link
Contributor Author

alexco2 commented Oct 3, 2021

@PedroBern @andreialecu
Amazing. This is my first PR 🎉. Thank you for merging and releasing so fast. Really motivates me to commit further to this library!

@andreialecu
Copy link
Collaborator

Thank you @alexco2, keep 'em coming! 💯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade reanimated to stable + upgrade example app to expo SDK 41
3 participants