Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Sectionlist #97

Closed
alexco2 opened this issue Feb 4, 2021 · 11 comments
Closed

Support for Sectionlist #97

alexco2 opened this issue Feb 4, 2021 · 11 comments
Labels
blocked on upstream good first issue Good for newcomers question Further information is requested

Comments

@alexco2
Copy link
Contributor

alexco2 commented Feb 4, 2021

Hello, first of all, amazing package. This is something the rn community definetly needs! One question though. Do you plan to support Sectionlist, or is there a way to make it work with sectionlist?

@alexco2 alexco2 added the question Further information is requested label Feb 4, 2021
@PedroBern PedroBern added the good first issue Good for newcomers label Feb 5, 2021
@andreialecu
Copy link
Collaborator

The refactoring made as part of #93 should make this very easy to add.

@andreialecu
Copy link
Collaborator

This will actually not be easily possible to do on iOS because of issues described in this comment: #136 (comment)

@RoscoeZhao
Copy link

Hi @andreialecu , firstly I want to say thank you for this great component!
The PR which fixs the iOS offset issue, facebook/react-native#30737 , has been merged to RN. Would you please add support for SectionList ? Thank you very much!

@andreialecu
Copy link
Collaborator

@RoscoeZhao unfortunately even though the PR was merged, RN0.64 does not include it.

You can verify by comparing https://cdn.jsdelivr.net/npm/react-native@0.64.0/React/Views/RefreshControl/RCTRefreshControl.m with the changes in the PR.

The release workflow of RN diverges from what is in master. Instead, they cherry pick commits:
react-native-community/releases#221

RN 0.64.1 is not scheduled to have it either, as per the thread linked above.

@alexco2
Copy link
Contributor Author

alexco2 commented Apr 14, 2021

I asked for a cherrypick. If you give the comment some attention, perhaps It'll work ;)

@davidbiedenbach
Copy link

I guess 30737 finally made it into 0.65 =)

@alexco2
Copy link
Contributor Author

alexco2 commented Sep 16, 2021

@andreialecu since the PR is now included in RN 0.65, is there a plan to support sectionlist as well? :)

@andreialecu
Copy link
Collaborator

Sure, we can consider a PR that adds section list support if anyone is willing to implement it. 🙂

@alexco2
Copy link
Contributor Author

alexco2 commented Sep 17, 2021

Are there some considerations that come into your mind regarding the implementation of SectionList? @andreialecu

@alexco2
Copy link
Contributor Author

alexco2 commented Sep 29, 2021

@andreialecu I was able to make SectionList work. I will test it further and commit a PR if everything works fine. Also, I will look into bumping reanimated to version 2.2.2 for an additional PR. #164

@alexco2
Copy link
Contributor Author

alexco2 commented Oct 1, 2021

I commited the PR. Please let me know if anything is missing. Would be happy if the feature could be merged and shipped :)
#201

@alexco2 alexco2 closed this as completed Oct 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked on upstream good first issue Good for newcomers question Further information is requested
Projects
None yet
Development

No branches or pull requests

5 participants