Feature/update phpunit 8 to 9 #536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 25, 2022
Closed
pierredup
reviewed
Feb 27, 2022
Co-authored-by: Pierre du Plessis <pierre@pcservice.co.za>
Co-authored-by: Pierre du Plessis <pierre@pcservice.co.za>
|
I have to thank you for maintaining payum. |
pierredup
approved these changes
Feb 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Changes are related to php 7.4 and phpunit 9 and to get tests running.
This PR is related to #535
Serveral changes are needed in composer.json
"league/uri-schemes": "^1.1", => Otherwise it would not install on php 8.x
"payum/payum": "^1.6.2", => Otherwise --prefer-lowest Test will not be an installable set
"symfony/phpunit-bridge": "6.0", => Only one version is needed for require-dev
"psr/log": "^1 || ^2", is more a temporary fix. I guesss the real problem is in payum itself. Payum/Payum#926
"symfony/form": "^4.4.20 || ^5.0", => Required for the test (Annotated Validations) CreditCardTypeTest->shouldRequireExpireAtInFuture()
Update: All Tests are migrated to phpUnit 9.
Symfony4 needs some extra config to work with Symfony4, 5 and 6 in the near future.
Symfony6 will need extra Work, as there are deprecated functions.
Should be handled in an different PR, after support of Symfony6 is added.