feat: add typehints for factories #538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pierredup
approved these changes
Feb 27, 2022
There was a problem hiding this comment.
Personally I don't consider this as a BC break, since everything in the DependencyInjection namespace is not part of the public api and is for internal usage only. So anyone extending these classes, do so at their own risk.
(Once #536 is merged, this branch can be rebased to get the builds green)
Chris53897
changed the title
|
Thanks for the explanation. Since there are no conflicts with |
|
Thank you @Chris53897 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needs review and testing. See #536
Could be BC Break if User extend these factories.
The interface is not changed.
Can someone explain the background why in the Interface the ReturnTypes are not set, and
$modelClassis not TypeHinted withstringin the past?