Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporary disable isort due to upstream bug #4538

Merged
merged 1 commit into from Jan 29, 2023

Conversation

sijunhe
Copy link
Collaborator

@sijunhe sijunhe commented Jan 29, 2023

PR types

PR changes

Description

Turning off isort temporary due to PyCQA/isort#2077
As of 2023.1.29, bumping isort to 5.12.0 would resolve the error but requires python3.8+
Track the issue: PyCQA/isort#2083

@paddle-bot
Copy link

paddle-bot bot commented Jan 29, 2023

Thanks for your contribution!

Copy link
Contributor

@wj-Mcat wj-Mcat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Jan 29, 2023

Codecov Report

Merging #4538 (a52a418) into develop (45dab3f) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #4538   +/-   ##
========================================
  Coverage    41.26%   41.26%           
========================================
  Files          433      433           
  Lines        61777    61777           
========================================
+ Hits         25493    25494    +1     
+ Misses       36284    36283    -1     
Impacted Files Coverage Δ
paddlenlp/utils/downloader.py 58.19% <0.00%> (+0.40%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@sijunhe sijunhe merged commit 12d15f9 into PaddlePaddle:develop Jan 29, 2023
@sijunhe sijunhe deleted the fix-isort branch January 29, 2023 04:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants