Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Function optimization] Add test for autoconverter of Bert/GPT models #4537

Merged
merged 3 commits into from
Jan 30, 2023

Conversation

wj-Mcat
Copy link
Contributor

@wj-Mcat wj-Mcat commented Jan 29, 2023

PR types

Function optimization

PR changes

Tests

Description

为Bert/GPT 模型批量添加更多的AutoConverter单测。

由于 t5 最核心的模型是 T5ModelT5ForConditionalGeneration,不适合批量添加更多下游模型,故在此不针对于 t5 系列模型做更多的调整。

@paddle-bot
Copy link

paddle-bot bot commented Jan 29, 2023

Thanks for your contribution!

@codecov
Copy link

codecov bot commented Jan 29, 2023

Codecov Report

Merging #4537 (899415d) into develop (6d24a53) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff            @@
##           develop    #4537   +/-   ##
========================================
  Coverage    41.31%   41.32%           
========================================
  Files          433      433           
  Lines        61820    61826    +6     
========================================
+ Hits         25540    25547    +7     
+ Misses       36280    36279    -1     
Impacted Files Coverage Δ
paddlenlp/transformers/bert/modeling.py 90.28% <100.00%> (+0.05%) ⬆️
paddlenlp/transformers/gpt/modeling.py 78.60% <100.00%> (+0.17%) ⬆️
paddlenlp/utils/downloader.py 58.60% <0.00%> (+0.40%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@wj-Mcat
Copy link
Contributor Author

wj-Mcat commented Jan 29, 2023

there is an ci error in isort package, it seems that it's kown issue: pre-commit fails to install isort 5.11.4 with error "RuntimeError: The Poetry configuration is invalid".

So, I will try to upgrade the version of isort to 5.12.0.


this problem is fixed by #4538

@wj-Mcat wj-Mcat marked this pull request as ready for review January 29, 2023 04:51
@sijunhe
Copy link
Collaborator

sijunhe commented Jan 29, 2023

lgtm. merge一下develop重新trigger一下lint 我再approve

Copy link
Collaborator

@sijunhe sijunhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sijunhe sijunhe merged commit af708cd into PaddlePaddle:develop Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants