Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add fully_qualified_strict_types fixer import_relative_symbols option #7721

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

mvorisek
Copy link
Contributor

@mvorisek mvorisek commented Jan 13, 2024

finish after #7719

TODO for myself - import \Ns\Exception even if there is \Exception in the code before

@mvorisek mvorisek changed the title Add fully_qualified_strict_types fixer import_relative_symbols option feat: add fully_qualified_strict_types fixer import_relative_symbols option Jan 13, 2024
@Wirone
Copy link
Member

Wirone commented Jan 13, 2024

As I already mentioned, I would prefer import_symbols to be bool or ['classes' => true, 'constants' => true, 'functions' => true, 'allow_relative' => true] (all options related to importing grouped under main option), with normaliser defined to support both (bool value means all the sub-options takes that value). I even have it implemented locally, just did not have time to finish it 😅.

This is only early feedback after seeing PR, did not take a look at implementation yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants